Layer 2 MCP Watcher v0 scaffold
Per spec/agent-watcher.md §4. TypeScript/Node implementation living in
mcp-watcher/ subdirectory, parallel to Layer 1 Collector at repo root.
What lands:
- Core MCP server (src/server.ts) with experimental['claude/channel']:{}
+ tools:{} capability declarations, stdio transport, channel-event
notifier wired through the inbox watcher.
- Identity resolution mirroring agent-ping's layered model
(PING_AGENT_IDENTITY env, $CLAUDE_HOME/ping-agent, ~/.ping-agent).
- Inbox reader with HWM tracking, sentinel deferral (warn-after-3),
atomic HWM writes via tmp+rename.
- chokidar-backed file watcher with coalesced drain, urgent-first
ordering, recentEvents map for tool sender lookup.
- Three reply tools (ack / respond / mark_handled) with cross-host
write discipline (writes to local inbox files; Syncthing replicates).
- Sentinel file (.<agent>.watcher-active) for hook coexistence per
spec §4.3 — agent-ping hook stands down when the watcher is in
charge of delivery on this host. Sentinel + hwm in .stignore.
- 35 unit tests passing (vitest): inbox parsing, HWM round-trip,
sentinel deferral semantics, identity layers, tool I/O, watcher
drain + ordering + restart-from-hwm.
- install.sh (Angus-executed, rule-2 compliant) installs deps,
builds, symlinks ~/.local/bin/agent-watcher-mcp, prints mcp.json
registration snippet for paste.
- README documents launch flag, sandbox CLAUDE_HOME pattern,
hook coexistence, observability, v2 limitations.
Not yet:
- Integration test against a real Claude Code session — gated on
Angus spinning up a sandbox CC session on the VPS with
CLAUDE_HOME=~/.claude-sandbox.
- agent-ping hook update to read the sentinel and stand down.
Separate small PR against agent-ping.
Interface contract with Layer 1: the inbox JSONL line shape from
inbox.ts::PingEvent matches inbox.Event in the Collector — bit-
identical reads regardless of source.
This commit is contained in:
parent
3eda72df28
commit
c22558c67a
18 changed files with 4786 additions and 0 deletions
155
mcp-watcher/test/watcher.test.ts
Normal file
155
mcp-watcher/test/watcher.test.ts
Normal file
|
|
@ -0,0 +1,155 @@
|
|||
import { describe, it, expect, beforeEach, afterEach } from "vitest";
|
||||
import { mkdtempSync, writeFileSync, mkdirSync, appendFileSync, rmSync, readFileSync } from "node:fs";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join } from "node:path";
|
||||
import { makePaths } from "../src/paths.js";
|
||||
import { InboxWatcher } from "../src/watcher.js";
|
||||
import type { PingEvent } from "../src/inbox.js";
|
||||
|
||||
let dir: string;
|
||||
|
||||
beforeEach(() => {
|
||||
dir = mkdtempSync(join(tmpdir(), "watcher-watch-"));
|
||||
});
|
||||
afterEach(() => {
|
||||
rmSync(dir, { recursive: true, force: true });
|
||||
});
|
||||
|
||||
const ev = (over: Partial<PingEvent>): PingEvent => ({
|
||||
ts: "2026-05-06T10:00:00Z",
|
||||
id: "ping-" + Math.random().toString(36).slice(2, 10),
|
||||
from: "foreman",
|
||||
to: "bob",
|
||||
type: "INFO",
|
||||
payload: "test",
|
||||
...over,
|
||||
});
|
||||
|
||||
const writeInbox = (path: string, events: PingEvent[]) => {
|
||||
mkdirSync(join(path, "..").replace(/[^/]*\/?$/, ""), { recursive: true });
|
||||
writeFileSync(path, events.map((e) => JSON.stringify(e)).join("\n") + "\n");
|
||||
};
|
||||
|
||||
describe("InboxWatcher initial drain", () => {
|
||||
it("emits all unread events on start, then advances HWM", async () => {
|
||||
const paths = makePaths(dir);
|
||||
mkdirSync(paths.pingsDir, { recursive: true });
|
||||
writeInbox(paths.inbox("bob"), [
|
||||
ev({ id: "a", ts: "2026-05-06T10:00:00Z" }),
|
||||
ev({ id: "b", ts: "2026-05-06T11:00:00Z" }),
|
||||
]);
|
||||
|
||||
const delivered: { event: PingEvent; warning?: string }[] = [];
|
||||
const w = new InboxWatcher({
|
||||
paths,
|
||||
agent: "bob",
|
||||
notify: async (event, warning) => {
|
||||
delivered.push({ event, warning });
|
||||
},
|
||||
// No-op chokidar substitute
|
||||
startWatcher: () => ({ async close() {} }),
|
||||
});
|
||||
await w.start();
|
||||
await w.stop();
|
||||
|
||||
expect(delivered.map((d) => d.event.id)).toEqual(["a", "b"]);
|
||||
const hwm = JSON.parse(readFileSync(paths.hwm("bob"), "utf8"));
|
||||
expect(hwm.last_delivered_ts).toBe("2026-05-06T11:00:00Z");
|
||||
});
|
||||
|
||||
it("orders urgent before normal regardless of timestamp", async () => {
|
||||
const paths = makePaths(dir);
|
||||
mkdirSync(paths.pingsDir, { recursive: true });
|
||||
writeInbox(paths.inbox("bob"), [
|
||||
ev({ id: "older-normal", ts: "2026-05-06T10:00:00Z", priority: "normal" }),
|
||||
ev({ id: "newer-urgent", ts: "2026-05-06T11:00:00Z", priority: "urgent" }),
|
||||
]);
|
||||
|
||||
const delivered: PingEvent[] = [];
|
||||
const w = new InboxWatcher({
|
||||
paths, agent: "bob",
|
||||
notify: async (e) => { delivered.push(e); },
|
||||
startWatcher: () => ({ async close() {} }),
|
||||
});
|
||||
await w.start();
|
||||
await w.stop();
|
||||
expect(delivered.map((d) => d.id)).toEqual(["newer-urgent", "older-normal"]);
|
||||
});
|
||||
|
||||
it("defers a sentinel-missing ping and re-attempts on next drain", async () => {
|
||||
const paths = makePaths(dir);
|
||||
mkdirSync(paths.pingsDir, { recursive: true });
|
||||
writeInbox(paths.inbox("bob"), [ev({ id: "a", sentinel: "/nope" })]);
|
||||
|
||||
const delivered: PingEvent[] = [];
|
||||
let triggerChange: () => void = () => {};
|
||||
const w = new InboxWatcher({
|
||||
paths, agent: "bob",
|
||||
notify: async (e) => { delivered.push(e); },
|
||||
sentinelExists: () => false,
|
||||
startWatcher: (_path, onChange) => {
|
||||
triggerChange = onChange;
|
||||
return { async close() {} };
|
||||
},
|
||||
});
|
||||
await w.start();
|
||||
expect(delivered).toEqual([]);
|
||||
// hwm has pending_attempts.a = 1 but ts not advanced
|
||||
let hwm = JSON.parse(readFileSync(paths.hwm("bob"), "utf8"));
|
||||
expect(hwm.pending_attempts).toEqual({ a: 1 });
|
||||
expect(hwm.last_delivered_ts).toBe("");
|
||||
|
||||
// Two more triggers — third delivery emits with warning
|
||||
triggerChange();
|
||||
await new Promise((r) => setTimeout(r, 10));
|
||||
triggerChange();
|
||||
await new Promise((r) => setTimeout(r, 10));
|
||||
|
||||
expect(delivered.map((d) => d.id)).toEqual(["a"]);
|
||||
hwm = JSON.parse(readFileSync(paths.hwm("bob"), "utf8"));
|
||||
expect(hwm.pending_attempts).toEqual({});
|
||||
expect(hwm.last_delivered_ts).toBe("2026-05-06T10:00:00Z");
|
||||
await w.stop();
|
||||
});
|
||||
|
||||
it("populates recentEvents map for tools to look up sender", async () => {
|
||||
const paths = makePaths(dir);
|
||||
mkdirSync(paths.pingsDir, { recursive: true });
|
||||
writeInbox(paths.inbox("bob"), [
|
||||
ev({ id: "ping-x", from: "mom" }),
|
||||
ev({ id: "ping-y", from: "foreman" }),
|
||||
]);
|
||||
const w = new InboxWatcher({
|
||||
paths, agent: "bob",
|
||||
notify: async () => {},
|
||||
startWatcher: () => ({ async close() {} }),
|
||||
});
|
||||
await w.start();
|
||||
expect(w.recentEvents().get("ping-x")?.from).toBe("mom");
|
||||
expect(w.recentEvents().get("ping-y")?.from).toBe("foreman");
|
||||
await w.stop();
|
||||
});
|
||||
|
||||
it("skips pings already covered by HWM on restart", async () => {
|
||||
const paths = makePaths(dir);
|
||||
mkdirSync(paths.pingsDir, { recursive: true });
|
||||
writeInbox(paths.inbox("bob"), [
|
||||
ev({ id: "a", ts: "2026-05-06T10:00:00Z" }),
|
||||
ev({ id: "b", ts: "2026-05-06T11:00:00Z" }),
|
||||
]);
|
||||
writeFileSync(
|
||||
paths.hwm("bob"),
|
||||
JSON.stringify({ last_delivered_ts: "2026-05-06T10:00:00Z", pending_attempts: {} }),
|
||||
);
|
||||
|
||||
const delivered: PingEvent[] = [];
|
||||
const w = new InboxWatcher({
|
||||
paths, agent: "bob",
|
||||
notify: async (e) => { delivered.push(e); },
|
||||
startWatcher: () => ({ async close() {} }),
|
||||
});
|
||||
await w.start();
|
||||
await w.stop();
|
||||
expect(delivered.map((d) => d.id)).toEqual(["b"]);
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue